Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Customers Update/Create pages #16458

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Cover Customers Update/Create pages #16458

merged 5 commits into from
Jul 3, 2024

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Jun 25, 2024 •
edited
Loading

Q A
Branch? 2.0
Bug fix? no
New feature? yes
BC breaks? yes
License MIT

Screenshot 2024-07-03 at 10 42 31

@TheMilek TheMilek added the Admin AdminBundle related issues and PRs. label Jun 25, 2024
@TheMilek TheMilek requested review from a team as code owners June 25, 2024 11:39
TheMilek
TheMilek commented Jun 25, 2024
View reviewed changes
...res/admin/user/managing_customers/being_able_to_create_account_for_existing_customer.feature Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted, as we abandoned the "can log in?" toggle

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@TheMilek TheMilek mentioned this pull request Jun 26, 2024
Merged
NoResponseMate added a commit that referenced this pull request Jun 26, 2024
@NoResponseMate
minor #16465 Deprecate CustomerTypeExtension and AddUserFormSubscribe…
85b53f2 
…r (TheMilek)

This PR was merged into the 1.14 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.14  <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | yes <!-- don't forget to update the UPGRADE-*.md file -->
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.12 or 1.13 branches
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
[REF](#16458)


Commits
-------
  Deprecate CustomerTypeExtension and AddUserFormSubscriber
@TheMilek TheMilek force-pushed the SYL-3191 branch 2 times, most recently from 1e59ec6 to 18e7ec1 Compare July 3, 2024 08:49
Wojdylak
Wojdylak approved these changes Jul 3, 2024
View reviewed changes
src/Sylius/Bundle/AdminBundle/templates/customer/form/sections/account_credentials.html.twig
Comment on lines +9 to +11
<div class="alert alert-info">
{{ 'sylius.ui.account_credentials_details'|trans }}
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should only be visible if the shop user has not been created.

@GSadee GSadee merged commit e818fb3 into Sylius:2.0 Jul 3, 2024
19 checks passed
@TheMilek TheMilek deleted the SYL-3191 branch July 3, 2024 09:53
@TheMilek TheMilek mentioned this pull request Jul 3, 2024
Merged
NoResponseMate added a commit that referenced this pull request Jul 3, 2024
@NoResponseMate
minor #16514 Customer create edit page fixes (TheMilek)
6f6d622 
This PR was merged into the 2.0 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
[REF](#16458)

Commits
-------
  Customer create edit page fixes
GSadee pushed a commit to Sylius/SyliusAdminBundle that referenced this pull request Jul 18, 2024
@NoResponseMate
minor #16514 Customer create edit page fixes (TheMilek)
df48e3a 
This PR was merged into the 2.0 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
[REF](Sylius/Sylius#16458)

Commits
-------
  Customer create edit page fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate left review comments

@Wojdylak Wojdylak Wojdylak approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheMilek @GSadee @NoResponseMate @Wojdylak