Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles for thank-you page #16424

Merged

Conversation

bartek-sek
Copy link
Contributor

@bartek-sek bartek-sek commented Jun 18, 2024

New thank-you page:
image

@bartek-sek bartek-sek requested review from a team as code owners June 18, 2024 10:17
@probot-autolabeler probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Jun 18, 2024
Copy link

github-actions bot commented Jun 18, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let’s stick with the snake_case convention for the file name. Also, it should look nicer with centered text. Also, the HTML looks a bit too complex, IMO a simple container with text center and some margins should be enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented adjustments as requested

@kulczy
Copy link
Member

kulczy commented Jun 20, 2024

thanks @bartek-sek 🤜

@kulczy kulczy merged commit 4ab99c7 into Sylius:bootstrap-shop Jun 20, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants