Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin][CatalogPromotion] Add create and update pages #16133

Merged
merged 11 commits into from
Apr 23, 2024
Merged

[Admin][CatalogPromotion] Add create and update pages #16133

merged 11 commits into from
Apr 23, 2024

Conversation

Wojdylak
Copy link
Member

@Wojdylak Wojdylak commented Apr 17, 2024 •
edited
Loading

Q A
Branch? bootstrap-admin-panel
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets N/A
License MIT

image

@Wojdylak Wojdylak requested review from a team as code owners April 17, 2024 16:16
@Wojdylak Wojdylak marked this pull request as draft April 17, 2024 16:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

Bunnyshell Preview Environment deployed

It will be automatically stopped in 4 hours.

Use the command /bns:start to start it if it's stopped.

Component Endpoints
mailhog https://mailhog-ftg3x3.bunnyenv.com/
php https://store-ftg3x3.bunnyenv.com/

Available commands:

  • /bns:stop to stop the environment
  • /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@Wojdylak Wojdylak force-pushed the SYL-3196-catalog-promotions-create-update branch from 0e44d38 to 826f082 Compare April 18, 2024 14:08
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Apr 18, 2024
@Wojdylak Wojdylak changed the title 🚧 [Admin][CatalogPromotion] Add create and update pages [Admin][CatalogPromotion] Add create and update pages Apr 18, 2024
@Wojdylak Wojdylak marked this pull request as ready for review April 18, 2024 15:17
mpysiak
mpysiak approved these changes Apr 22, 2024
View reviewed changes
src/Sylius/Behat/Element/Admin/CatalogPromotion/FormElement.php
public function __construct(
Session $session,
$minkParameters = [],
private readonly AutocompleteHelperInterface $autocompleteHelper,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional parameter before required. This will trigger warning

@Wojdylak Wojdylak force-pushed the SYL-3196-catalog-promotions-create-update branch from 5450d9f to 9773705 Compare April 22, 2024 05:59
@TheMilek TheMilek merged commit fa4af3d into Sylius:bootstrap-admin-panel Apr 23, 2024
19 checks passed
@Wojdylak Wojdylak deleted the SYL-3196-catalog-promotions-create-update branch May 23, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpysiak mpysiak mpysiak approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wojdylak @GSadee @mpysiak @TheMilek