Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Channel resource to API Platform 3 #16126

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Upgrade Channel resource to API Platform 3 #16126

merged 5 commits into from
Apr 18, 2024

Conversation

TheMilek
Copy link
Member

Q A
Branch? api-platform-3
Bug fix? no
New feature? yes
BC breaks? no
License MIT

@TheMilek TheMilek added the API APIs related issues and PRs. label Apr 16, 2024
@TheMilek TheMilek requested review from a team as code owners April 16, 2024 14:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@TheMilek TheMilek mentioned this pull request Apr 17, 2024
Merged
@TheMilek TheMilek force-pushed the SYL-3458 branch 4 times, most recently from 176649e to 1060c5c Compare April 17, 2024 14:40
@NoResponseMate NoResponseMate merged commit 01f159e into Sylius:api-platform-3 Apr 18, 2024
19 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @TheMilek!

@TheMilek TheMilek deleted the SYL-3458 branch April 18, 2024 14:43
NoResponseMate added a commit that referenced this pull request Apr 18, 2024
@NoResponseMate
minor #16130 Enable behat tests for Channel after upgrade to APIP 3 (…
50f9b5e 
…TheMilek)

This PR was merged into the api-platform-3 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | api-platform-3 <!-- see the comment below -->                  |
| Bug fix?        | no                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->

continuation of #16126


Commits
-------
  Enable channel behat tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@Wojdylak Wojdylak Wojdylak approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheMilek @NoResponseMate @Wojdylak