Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform Product Create/Update form into Live Component #15845

Merged
merged 32 commits into from
Feb 28, 2024
Merged

Transform Product Create/Update form into Live Component #15845

merged 32 commits into from
Feb 28, 2024

Conversation

jakubtobiasz
Copy link
Contributor

No description provided.

@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Feb 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited
Loading

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz jakubtobiasz force-pushed the bap/product-attributes branch from 5c5678f to 77a1d53 Compare February 14, 2024 14:17
@probot-autolabeler probot-autolabeler bot added the Docker Docker-related issues and PRs. label Feb 14, 2024
@jakubtobiasz
Copy link
Contributor Author

/bns:deploy

2 similar comments
@jakubtobiasz
Copy link
Contributor Author

/bns:deploy

@CoderMaggie
Copy link
Member

/bns:deploy

@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Feb 22, 2024
@jakubtobiasz jakubtobiasz marked this pull request as ready for review February 23, 2024 11:55
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner February 23, 2024 11:55
@jakubtobiasz jakubtobiasz force-pushed the bap/product-attributes branch from b37ef47 to 0b669a7 Compare February 23, 2024 11:57
@jakubtobiasz jakubtobiasz marked this pull request as draft February 23, 2024 11:57
@jakubtobiasz jakubtobiasz force-pushed the bap/product-attributes branch 7 times, most recently from 6effe0f to 4b89d96 Compare February 23, 2024 20:53
jakubtobiasz
jakubtobiasz commented Feb 24, 2024
View reviewed changes
behat.yml.dist Outdated
@@ -26,7 +26,7 @@ default:
files_path: "%paths.base%/src/Sylius/Behat/Resources/fixtures/"
base_url: "https://127.0.0.1:8080/"
default_session: symfony
javascript_session: panther
javascript_session: chromedriver
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something bad happened, and for unknown reason GitHub Actions can't run Chrome on the CI. Let's go with switching to the chromedriver for now, and trying to fix it later.

jakubtobiasz
jakubtobiasz commented Feb 24, 2024
View reviewed changes
composer.json
@@ -190,7 +191,8 @@
"conflict": {
"doctrine/orm": ">= 2.16.0",
"lexik/jwt-authentication-bundle": "^2.18",
"stof/doctrine-extensions-bundle": "1.8.0"
"stof/doctrine-extensions-bundle": "1.8.0",
"symfony/ux-live-component": "2.15.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symfony/ux#1547

jakubtobiasz
jakubtobiasz commented Feb 24, 2024
View reviewed changes
features/admin/product/managing_products/editing_product_attributes.feature Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I changed the way how the product attributes autocomplete works (it no longer keeps the added attributes) these scenarios became obsolete.

@jakubtobiasz jakubtobiasz force-pushed the bap/product-attributes branch from 4b89d96 to 4591238 Compare February 24, 2024 13:26
jakubtobiasz
jakubtobiasz commented Feb 24, 2024
View reviewed changes
...in/product/managing_products/managing_attributes/adding_product_with_float_attribute.feature
Scenario: Adding a float attribute to a product
When I want to create a new configurable product
And I specify its code as "display_size"
And I name it "Smartphone" in "English (United States)"
And I add the "Display Size" attribute to it
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to split adding the attribute and setting its value

@jakubtobiasz jakubtobiasz force-pushed the bap/product-attributes branch 2 times, most recently from e8b65b9 to 348eef1 Compare February 24, 2024 16:28
@jakubtobiasz
Cover "Adding and removing text attributes on product update page"
109b498
@jakubtobiasz
Cover "Adding and removing after saving text attributes on product up…
4428765 
…date page"
@jakubtobiasz
Cover "Adding a product with a text attribute in different locales"
f6a031b
@jakubtobiasz
Cover "Adding a text attribute in different locales to an existing pr…
f402e6a 
…oduct"
@jakubtobiasz
Cover "Adding a product with a select attribute with choices in diffe…
3a4424e 
…rent locales"
@jakubtobiasz
Move product attributes management scenarios into their own directory
8e7b5a1
@jakubtobiasz
Cover "Seeing message about no new attributes selected"
c40ffe5
@jakubtobiasz
Remove outdated behat scenario
bb66f3e
@jakubtobiasz
Partially cover "Adding a new product with text attribute" scenarios
8a59897
@jakubtobiasz
Cover "Adding a percent attribute to product" scenario
4e258e5
@jakubtobiasz
Cover "Adding an integer attribute to product" scenario
4676db4
@jakubtobiasz
Implement handling non-translatable attributes
4906c87
@jakubtobiasz
Bump symfony/ux-autocomplete to ^2.15
f34799d
@jakubtobiasz
Fix PHPStan errors
6455156
@jakubtobiasz
Install autocomplete in the AdminBundle
e6bfb4e
@jakubtobiasz
Add a conflict for the Live Components 2.15.0
ae5415b
@jakubtobiasz
Make the checking notifications more stable
e9fb577
@jakubtobiasz
Move the autocomplete endpoint behind the admin firewall
6b3c87c
@jakubtobiasz
Bring back the .gitignore file
11d0da3
@jakubtobiasz
Revert the method signature
d8fd062
@jakubtobiasz
Provide minor fixes
983c477
@jakubtobiasz jakubtobiasz force-pushed the bap/product-attributes branch from 348eef1 to 983c477 Compare February 25, 2024 13:33
@jakubtobiasz jakubtobiasz marked this pull request as ready for review February 25, 2024 18:37
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner February 25, 2024 18:37
@Wojdylak Wojdylak merged commit dee30d3 into Sylius:bootstrap-admin-panel Feb 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMilek TheMilek TheMilek approved these changes

@Wojdylak Wojdylak Wojdylak approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Docker Docker-related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakubtobiasz @CoderMaggie @NoResponseMate @Wojdylak @TheMilek