[Maintenance] Update dependencies Symfony/password-hasher #13358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Dec 6, 2021
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
probot-autolabeler
bot
added
the
Maintenance
AdamKasp
added a commit
that referenced
this pull request
Dec 6, 2021
…e, lchrusciel) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Backport of #13339 and #13358, fixes Sylius/Sylius-Standard#630 | License | MIT Let's bring Sf5.4 support to Sylius 1.10. This way, current users will benefit from Symfony 5.4 with current installations. I'm considering it as a bug-fix, as it is already possible to install this version according to our composer.json. What is more, it will make it possible to migrate first to Sf5.4 and then upgrade to Sylius 1.11. <!-- - Bug fixes must be submitted against the 1.10 branch - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 860c3e8 [Maintanance] add conflict 71e4fd6 feature #13339 Add Support for Symfony 5.4 (AdamKasp) 860399f [Minor] Fix CONFLICT.md lining 5937ebb [Maintenance] Conflict with Symfony ^6.0
mbabker
reviewed
Dec 6, 2021
| @@ -3,6 +3,10 @@ | |||
| This document explains why certain conflicts were added to `composer.json` and | |||
| references related issues. | |||
|
|
|||
| - `symfony/password-hasher": "^6.0`: | |||
|
|
|||
| Symfony in version 5.3 change password hashing logic, and in version 6.0 they removed BC layer | |||
There was a problem hiding this comment.
I'm going to try and reword this a little bit to better explain the actual reason for conflict here. Also, I'm not quite sure if the conflict should actually be against the Password Hasher component or the Security-Core component (or both) as Sylius is dependent on the API from the Security-Core component and not yet aware of the Password Hasher component.
Suggested change
| Symfony in version 5.3 change password hashing logic, and in version 6.0 they removed BC layer | |
| In Symfony 5.3, the Password Hasher component was introduced and extracted the password encoders out of the Security-Core component. In 6.0, the B/C layer is removed. |
|
You currently reference "symfony/security-hasher" as conflict, but this should ofcourse be "symfony/password-hasher" |
|
Hey folks, this change has been already merged in #13357. Thanks for raising your concerns. If you may, please open appropriate PRs with improved conflicts :) |
Zales0123
added a commit
that referenced
this pull request
Dec 13, 2021
This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Leftover from #13357 and #13358 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 branch - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- e3ba9b9 [Docs] Add missing references in CONFLICT.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.