Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix default sylius config file path in Sylius 1.10 #13020

Merged
merged 1 commit into from
Aug 30, 2021
Merged

[Bug] Fix default sylius config file path in Sylius 1.10 #13020

merged 1 commit into from
Aug 30, 2021

Conversation

lchrusciel
Copy link
Member

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

There is no such file as app/config/packages/_sylius.yaml. App prefix is not needed, because related configuration should be placed in: https://github.com/Sylius/Sylius-Standard/blob/1.10/config/packages/_sylius.yaml

@lchrusciel lchrusciel added Maintenance CI configurations, READMEs, releases, etc. Bug Confirmed bugs or bugfixes. labels Aug 27, 2021
@lchrusciel lchrusciel requested a review from a team as a code owner August 27, 2021 14:05
@GSadee GSadee merged commit 1ec9f82 into Sylius:1.10 Aug 30, 2021
@GSadee
Copy link
Member

GSadee commented Aug 30, 2021

Thanks, Łukasz! 🎉

@lchrusciel lchrusciel deleted the config-file-1.10 branch August 30, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lchrusciel @GSadee @CoderMaggie