[Locale]Available locales in channel by api #12766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Jul 1, 2021
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
AdamKasp
force-pushed
the
available-locales-in-channel-by-api
branch
9 times, most recently
from
bd53e4d to
c6807b4
Compare
AdamKasp
changed the title
AdamKasp
force-pushed
the
available-locales-in-channel-by-api
branch
from
c6807b4 to
d516bf1
Compare
GSadee
reviewed
Jul 2, 2021
features/locale/getting_available_locales_in_current_channel.feature
Outdated
Show resolved
Hide resolved
| public function theLocaleWithCodeShouldBeAvailable(string $name, string $code): void | ||
| { | ||
| Assert::true( | ||
| $this->isLocaleWithName($name, $this->responseChecker->getCollection($this->client->getLastResponse())) |
There was a problem hiding this comment.
Suggested change
| $this->isLocaleWithName($name, $this->responseChecker->getCollection($this->client->getLastResponse())) | |
| $this->isLocaleWithName($this->responseChecker->getCollection($this->client->getLastResponse()), $name) |
There was a problem hiding this comment.
And what is more, I guess that you can use here getCollectionItemsWithValue method from ResponseChecker
There was a problem hiding this comment.
I've replaced this method in the next PR :)
src/Sylius/Bundle/ApiBundle/DataProvider/LocaleCollectionDataProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/LocaleCollectionDataProvider.php
Show resolved
Hide resolved
probot-autolabeler
bot
added
the
Maintenance
lchrusciel
reviewed
Jul 5, 2021
src/Sylius/Bundle/ApiBundle/Resources/config/services/data_providers.xml
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
available-locales-in-channel-by-api
branch
13 times, most recently
from
85c0318 to
981b4a2
Compare
AdamKasp
force-pushed
the
available-locales-in-channel-by-api
branch
3 times, most recently
from
9e0b889 to
fcd51d2
Compare
Tomanhez
reviewed
Jul 6, 2021
AdamKasp
force-pushed
the
available-locales-in-channel-by-api
branch
from
fcd51d2 to
90ceff6
Compare
arti0090
approved these changes
Jul 7, 2021
src/Sylius/Bundle/ApiBundle/DataProvider/LocaleCollectionDataProvider.php
Show resolved
Hide resolved
GSadee
approved these changes
Jul 7, 2021
src/Sylius/Bundle/ApiBundle/DataProvider/LocaleCollectionDataProvider.php
Show resolved
Hide resolved
SirDomin
approved these changes
Jul 7, 2021
|
Thanks, Adam! 🥇 |
GSadee
added a commit
that referenced
this pull request
Jul 7, 2021
This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no/ | Related tickets | based #12766 | License | MIT Commits ------- 5e7663e [Locales] Create ADR for locales exposing 4699cf1 [Locales] Create ADR for locales exposing 996343d [Locale] refactor get locale responses bc2d6e8 [Locales][API] disable pagination for locale and minor fixes
AdamKasp
added a commit
that referenced
this pull request
Mar 18, 2022
…ng the approach (GSadee) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #12766 and #13333 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 4e82e09 [ADR][API] Update ADR for providing locales after changing the approach ff3d798 [ADR][API] Reject the old one and add the new ADR for providing locales after changing the approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.