Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add missing inStock field to swagger #12653

Merged
merged 2 commits into from
May 24, 2021
Merged

[API] Add missing inStock field to swagger #12653

merged 2 commits into from
May 24, 2021

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented May 20, 2021 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes (missed thing)
BC breaks? no
Deprecations? no
Related tickets Extends #12639
License MIT

I forgot to add this to PR, forgive me sylius 🙏

@arti0090 arti0090 requested a review from a team as a code owner May 20, 2021 06:23
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label May 20, 2021
lchrusciel
lchrusciel previously approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgiveness granted

GSadee
GSadee requested changes May 20, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost sure, that this field has been added to ProductVariant, not Product

@arti0090
Copy link
Contributor Author

Thats true @GSadee i am just changing it

@lchrusciel lchrusciel dismissed their stale review May 20, 2021 06:57

@GSadee had a good point

@arti0090
Copy link
Contributor Author

Zrzut ekranu 2021-05-20 o 09 04 11

Changed for ProductVariant, also fixed the missing price field

@arti0090 arti0090 force-pushed the add-missing-inStock-field-to-swagger branch from c9266ac to 6798ade Compare May 20, 2021 07:24
@GSadee GSadee merged commit 3eedfde into Sylius:master May 24, 2021
@GSadee
Copy link
Member

GSadee commented May 24, 2021

Thank you, @arti0090! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arti0090 @GSadee @lchrusciel