[Documentation] Add hint about disabling autowire when extending a controller #10706
Conversation
adrianmarte
commented
Sep 25, 2019
adrianmarte
commented
| Q | A |
|---|---|
| Branch? | 1.6 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | mentioned in #9353 |
| License | MIT |
| methods: [GET] | ||
| defaults: | ||
| _controller: app.controller.shop.homepage:customAction | ||
| _controller: app.controller.product:showAction |
There was a problem hiding this comment.
It shouldn't work, this service should still be named sylius.controller.product. Current documentation seems ok for me. Can you explain your problem briefly?
There was a problem hiding this comment.
The documentation is in my opinion a bit misleading.
In the chapter "How to customize a Resource Controller?" there's described how to create the App\Controller\ProductController to overwrite sylius.controller.product. So it should be mentioned in this chapter how to configure the route for it.
But I understand now, that this doc is heavily relying on the linked pull request und with that it makes more sense, and will think again how to possible improve the docs. Because in my option there are too much dependencies to the pull request, which does not ONLY override a controller, but also the repository.
So at the moment I have the idea to add a second, simpler pull request to link in the docs which just overrides controller...
There was a problem hiding this comment.
I would love to review and merge it :)
And I'm aware that our docs require a few improvements here and there. Thanks for understanding and help :)
Zales0123
added
the
Documentation
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
Stale
stale
bot
removed
the
Stale
This PR was merged into the 1.5 branch. Discussion ---------- Commits ------- 1c8e9aa Fix typo in PromotionCouponFactoryInterface
lchrusciel
force-pushed
the
docs/improving_how-to-customize-a-resource-controller
branch
from
bab242d to
47096a6
Compare
… html requests (pfazzi) This PR was merged into the 1.5 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.6 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes Sylius#10930 | License | MIT Commits ------- c6cea6f [API] Fixed OrderController save action issue in not html requests
lchrusciel
force-pushed
the
docs/improving_how-to-customize-a-resource-controller
branch
from
47096a6 to
85f1e67
Compare
lchrusciel
force-pushed
the
docs/improving_how-to-customize-a-resource-controller
branch
from
85f1e67 to
d4ca7ee
Compare
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
|
There were some problems with commits so I've opened a new PR with your proposal(and your commits). I hope you don't mind. Closing in favor of #11019. |
…ending a controller (adrianmarte) This PR was merged into the 1.5 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.5 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | replaces #10706 | License | MIT Commits ------- 390b073 Improve docs for extending a controller b946dc9 Fix code block
