Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test doctrine migrations up & down #10666

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Test doctrine migrations up & down #10666

merged 1 commit into from
Sep 26, 2019

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Sep 10, 2019

Q A
Branch? 1.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

In CI, we test migration up during installation, but we never test down migrations.
This new Travis test checks doctrine migration up & down.

@loic425 loic425 requested a review from a team as a code owner September 10, 2019 09:47
@pamil pamil added the Maintenance CI configurations, READMEs, releases, etc. label Sep 26, 2019
@pamil pamil merged commit 02809f6 into Sylius:master Sep 26, 2019
@pamil
Copy link
Contributor

pamil commented Sep 26, 2019

Thanks, Loïc! 🥇

@loic425 loic425 deleted the features/test-doctrine-migrations branch September 27, 2019 07:03
@loic425 loic425 mentioned this pull request Sep 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic425 @pamil @lchrusciel