Travis with mySQL 5.7 + product sorting fix #10278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the createShopListQueryBuilder method of ProductRepository to get rid of the SQL error that causes a 500 one when trying to sort products by price in the shop.
Zales0123
added
Potential Bug
lchrusciel
approved these changes
Mar 29, 2019
|
Thank you, Mateusz! 🥇 |
Zales0123
added a commit
that referenced
this pull request
Apr 1, 2019
This PR was merged into the 1.3 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Since merging #10278 Travis jobs takes up to 50 minutes and are closed due to reaching a public repository job time limit :/ I don't know is it an issue with the mySQL version for 100%, but I think we should give it a try (check out travis-ci/travis-ci#9948). I hope it will work, as 50 minutes-long jobs are really painful 🔪 💀 Commits ------- 57f01f0 [Travis] Update mysql version to speed up builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug from issue #10266 has not been detected on Travis CI, due to the lower mySQL version (without
ONLY_FULL_GROUP_BYoption set). So this PR bumps the mySQL version on the Travis to 5.7 and contains the fix for the products sorting from #10274 (thank @laSyntez for this one!).As a proof that it didn't work without the fix, you can take a look at this build or check out our failing demo 🚀 🤣
We have also a PR with changing the ubuntu version on Travis to xenial (#10277), but it does not work for some reasons so bumping a mySQL version can be the first step 🖖