Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve taxon UI #10228

Merged
merged 3 commits into from
May 15, 2019
Merged

Improve taxon UI #10228

merged 3 commits into from
May 15, 2019

Conversation

kulczy
Copy link
Member

@kulczy kulczy commented Mar 14, 2019

Q A
Branch? 1.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9347
License MIT

mov

Zrzut ekranu 2019-03-14 o 10 14 32

Zrzut ekranu 2019-03-14 o 10 14 52

@kulczy kulczy requested a review from a team as a code owner March 14, 2019 09:28
@Zales0123 Zales0123 added UX Issues and PRs aimed at improving User eXperience. Admin AdminBundle related issues and PRs. labels Mar 14, 2019
@Zales0123 Zales0123 merged commit 78396d9 into Sylius:1.3 May 15, 2019
@Zales0123
Copy link
Member

Thanks, Szymon! 🥇

pamil added a commit that referenced this pull request May 15, 2019
…taxon tree changes (Zales0123)

This PR was merged into the 1.3 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.3
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #10228, #10365
| License         | 

Commits
-------

e539ee0 [Behat] Change scenarios to @javascript due to taxon tree changes
pamil added a commit that referenced this pull request Jun 19, 2019
This PR was merged into the 1.6-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

These scenarios were firstly problematic during #10228, so I've fixed it (apparently nope) by adding a [focus() method](2cec0b2#diff-f7ba951e53d61c2c9086e0a60c8cf788R49) on the element. However, it's still a problem in #10389. The thing is, in the javascript scenarios some other element is covering the "Save position" button if the screen size is too small 🚀 💃 

I've realized that we can avoid using an ajax call for saving positions, by using a `form` attribute on inputs. If this change will be welcomed, we can do the same for the variants' positions.

Commits
-------

0619052 [Behat] Avoid JS in product positions management scenarios
c904734 [Admin] Handle product positions update as a non-js request
feca621 PR review fixes
pamil added a commit to Sylius/SyliusAdminBundle that referenced this pull request Jun 20, 2019
This PR was merged into the 1.6-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

These scenarios were firstly problematic during Sylius/Sylius#10228, so I've fixed it (apparently nope) by adding a [focus() method](Sylius/Sylius@2cec0b2#diff-f7ba951e53d61c2c9086e0a60c8cf788R49) on the element. However, it's still a problem in Sylius/Sylius#10389. The thing is, in the javascript scenarios some other element is covering the "Save position" button if the screen size is too small 🚀 💃 

I've realized that we can avoid using an ajax call for saving positions, by using a `form` attribute on inputs. If this change will be welcomed, we can do the same for the variants' positions.

Commits
-------

0619052ee3890c3753ea7033f4b703639cc11f27 [Behat] Avoid JS in product positions management scenarios
c90473439a1d21c76800d3e6755e5e3237e6aeaa [Admin] Handle product positions update as a non-js request
feca62195785d3ccdaf205bb30c8b86049b48cdd PR review fixes
pamil added a commit to Sylius/SyliusCoreBundle that referenced this pull request Jun 20, 2019
This PR was merged into the 1.6-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

These scenarios were firstly problematic during Sylius/Sylius#10228, so I've fixed it (apparently nope) by adding a [focus() method](Sylius/Sylius@2cec0b2#diff-f7ba951e53d61c2c9086e0a60c8cf788R49) on the element. However, it's still a problem in Sylius/Sylius#10389. The thing is, in the javascript scenarios some other element is covering the "Save position" button if the screen size is too small 🚀 💃 

I've realized that we can avoid using an ajax call for saving positions, by using a `form` attribute on inputs. If this change will be welcomed, we can do the same for the variants' positions.

Commits
-------

0619052ee3890c3753ea7033f4b703639cc11f27 [Behat] Avoid JS in product positions management scenarios
c90473439a1d21c76800d3e6755e5e3237e6aeaa [Admin] Handle product positions update as a non-js request
feca62195785d3ccdaf205bb30c8b86049b48cdd PR review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants