Improve the ShippingBundle doc #9998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Konafets
commented
Dec 4, 2018
Konafets
commented
| Q | A |
|---|---|
| Branch? | 1.3 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
- Implement the methods
- Add setters
- Fix the getter call
lchrusciel
reviewed
Dec 4, 2018
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function setShippingWidth($width) |
There was a problem hiding this comment.
Shouldn't we add argument and return typehints as well?
Zales0123
added
the
Documentation
Zales0123
reviewed
Dec 4, 2018
|
@Zales0123 Do you mean |
lchrusciel
approved these changes
Dec 5, 2018
The Customer entity does not have have the mentioned properties.
This PR was merged into the 1.2 branch. Discussion ---------- The Customer entity does not have have the mentioned properties. | Q | A | --------------- | ----- | Branch? | 1.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT Commits ------- 34094b1 Remove billingAddress and shippingAddress
Implement the methods, add missing setters and fix the getter call.
* Add correct type hints `float` instead of `int` since the Interface expect `floats`. * Declare for strict types
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
|
Thank you, Stefano! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.