Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AppBundle from docs. #9995

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Remove AppBundle from docs. #9995

merged 1 commit into from
Dec 4, 2018

Conversation

Konafets
Copy link
Contributor

@Konafets Konafets commented Dec 4, 2018

Q A
Branch? 1.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9951
License MIT

The namespace AppBundle is still used in 1.3 docs. Even Symfony 4.x changed it to App. Remove or change it.

@Konafets
Remove AppBundle from docs.
d9433f4 
The namespace AppBundle is still used in 1.3 docs. Even Symfony 4.x changed it to App. Remove or change it.

Closes #9951
@Konafets Konafets requested a review from a team as a code owner December 4, 2018 12:10
@Konafets Konafets mentioned this pull request Dec 4, 2018
Closed
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Dec 4, 2018
CoderMaggie
CoderMaggie approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 💪

@lchrusciel lchrusciel merged commit afce2d0 into Sylius:1.3 Dec 4, 2018
@lchrusciel
Copy link
Member

Thanks, Stefano! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Konafets @lchrusciel @CoderMaggie @Zales0123