It's quite strange that this scenario passes... because it does not seem to work in dev environement 😕

It needs some more investigation, there is totally something wrong happening here 😄 I've also confirmed (by going to website manually) that on test env it works 💥

@Zales0123 In fact the origin of the problem is the PercentType field in Symfony that will save a float for any value different than 100 and an int for 100.

If I save value 99% I got this in configuration field of table sylius_promotion_action
a:1:{s:10:"percentage";d:0.99;}
And with value 100%, I got this
a:1:{s:10:"percentage";i:1;}

I think the BDD test does not see it because it bypass the Symfony form by creating directly promotion action with a percentage set to 1 as a float.

If needed we can chat about a different/better way to fix this issue on slack

I found a different way to fix this issue cf laurent35240@5ba1a2d

I've just checked that and it seems to work 💪 Could you please push the changes here so we could iterate over it and, hopefully, merge it? :)

Done

@laurent35240 the build failed, could you, please, take a look at it?

Sure, I will try to take a look at it this evening

@Zales0123 Build fixed ;-)

HI

@Zales0123 Do you want other corrections on this PR?

Thanks, Laurent! 🥇