Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing locales for product attributes #17558

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

bartek-sek
Copy link
Contributor

image

@bartek-sek bartek-sek requested review from a team as code owners December 9, 2024 10:33
Copy link

github-actions bot commented Dec 9, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@GSadee GSadee added UX Issues and PRs aimed at improving User eXperience. Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes. labels Dec 10, 2024
Comment on lines +1 to +5
{% set locale = hookable_metadata.context.locale_code|default(null) %}

{% if locale is not null %}
<span>{{ locale|sylius_locale_name }}</span>
{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set locale = hookable_metadata.context.locale_code|default(null) %}
{% if locale is not null %}
<span>{{ locale|sylius_locale_name }}</span>
{% endif %}
{% set locale_code = hookable_metadata.context.locale_code|default(null) %}
{% if locale_code is not null %}
<span>{{ locale_code|sylius_locale_name }}</span>
{% endif %}

@GSadee GSadee merged commit 18854f5 into Sylius:2.0 Dec 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants