[DX] Make services private #17276
Merged
[DX] Make services private #17276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mpysiak
commented
Oct 21, 2024
•
mpysiak
commented
| Q | A |
|---|---|
| Branch? | 2.0 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | n/a |
| License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
mpysiak
force-pushed
the
SYL-4026-make-services-private
branch
10 times, most recently
from
bd7fa7b to
ae02981
Compare
# Conflicts: # src/Sylius/Bundle/UserBundle/Resources/config/services.xml
# Conflicts: # src/Sylius/Bundle/PayumBundle/Resources/config/services.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/extension.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/factory.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/form.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/payment_request/action.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/payment_request/command_handler.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/payment_request/command_provider.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/payment_request/context.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/payment_request/factory.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/payment_request/processor.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/payment_request/resolver.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/provider.xml
# Conflicts: # src/Sylius/Bundle/PayumBundle/Resources/config/services/extension.xml # src/Sylius/Bundle/PayumBundle/Resources/config/services/payment_request/action.xml
# Conflicts: # src/Sylius/Bundle/ShopBundle/Resources/config/services/integrations/locale/storage.xml # src/Sylius/Bundle/ShopBundle/Resources/config/services/order_pay/providers.xml
# Conflicts: # src/Sylius/Bundle/CoreBundle/Resources/config/services.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/calculators.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/catalog_promotion.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/catalog_promotion/command_handlers.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/catalog_promotion/listeners.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/checkout.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/fixtures_factories.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/fixtures_listeners.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/installer.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/installer_requirements.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/listeners/workflow/order_payment.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/listeners/workflow/order_shipping.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/listeners/workflow/payment.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/listeners/workflow/shipment.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/mailer.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/price_history/command_handler.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/price_history/listeners.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/providers.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/shipping.xml
# Conflicts: # src/Sylius/Bundle/CoreBundle/Resources/config/services.xml
# Conflicts: # src/Sylius/Bundle/CoreBundle/Resources/config/services.xml # src/Sylius/Bundle/CoreBundle/Resources/config/services/promotion.xml
mpysiak
force-pushed
the
SYL-4026-make-services-private
branch
from
0afc037 to
b1c3bbf
Compare
Wojdylak
previously approved these changes
Oct 22, 2024
src/Sylius/Bundle/AdminBundle/Resources/config/services/controller.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/services/mailer.xml
Outdated
Show resolved
Hide resolved
Wojdylak
approved these changes
Oct 23, 2024
GSadee
added
DX
GSadee
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Add notes to an UPGRADE file and IMO, remove this ADR: https://github.com/Sylius/Sylius/blob/2.0/adr/2022_02_11_declaring_services_in_container.md, but it could be done in a separate PR 🖖🏻
GSadee
added a commit
that referenced
this pull request
Oct 23, 2024
| Q | A |-----------------|----- | Branch? | 2.0 | Bug fix? | no | New feature? | no | BC breaks? | no/ | Deprecations? | no | Related tickets | #17276 | License | MIT <!-- - Bug fixes must be submitted against the 1.13 branch - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.