Fix comparison of order items #17070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix comparison of order items when one of them is Doctrine proxy object
Bunnyshell Preview Environment deletedAvailable commands:
|
NoResponseMate
approved these changes
Oct 4, 2024
GSadee
approved these changes
Oct 4, 2024
|
Thank you, Jaroslav! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix comparison of order items when one of them is Doctrine proxy object
Having two OrderItem objects, with exact same content, but one of them Doctrine proxy, then comparison of
$orderItem instanceof staticin proxy object fails, because compared object is not a Doctrine proxy. That is probably not intentional and can break app in imports and other "I have created an order item copy and I am looking for original" situations.