[Shop] Allow using interfaces in components #16971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Sep 18, 2024
NoResponseMate
commented
| Q | A |
|---|---|
| Branch? | 2.0 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
NoResponseMate
added
Enhancement
Bunnyshell Preview Environment deletedAvailable commands:
|
mpysiak
force-pushed
the
SYL-3923/cover-shop-form-components
branch
2 times, most recently
from
1bbfc26 to
9d56136
Compare
GSadee
reviewed
Sep 20, 2024
src/Sylius/Bundle/UiBundle/Twig/Component/ResourceLivePropTrait.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Cart/WidgetComponent.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Product/SummaryComponent.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Product/Trait/ProductLivePropTrait.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Product/Trait/ProductLivePropTrait.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Product/Trait/ProductVariantLivePropTrait.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/UiBundle/Twig/Component/ResourceLivePropTrait.php
Outdated
Show resolved
Hide resolved
mpysiak
force-pushed
the
SYL-3923/cover-shop-form-components
branch
from
f68df6e to
6ddf72c
Compare
GSadee
reviewed
Sep 23, 2024
|
|
||
| #[LiveListener(FormComponent::SYLIUS_SHOP_CART_CHANGED)] | ||
| public function refreshCart(#[LiveArg] Order $cart): void | ||
| public function refreshCart(#[LiveArg] int $cart): void |
There was a problem hiding this comment.
Suggested change
| public function refreshCart(#[LiveArg] int $cart): void | |
| public function refreshCart(#[LiveArg] mixed $cartId): void |
mpysiak
force-pushed
the
SYL-3923/cover-shop-form-components
branch
from
e6b593c to
ecc0a24
Compare
Wojdylak
reviewed
Sep 23, 2024
Comment on lines
+14
to
+15
| use DefaultActionTrait; | ||
| use HookableLiveComponentTrait; |
There was a problem hiding this comment.
Is this needed? I didn't expect to see this here.
GSadee
approved these changes
Sep 23, 2024
Wojdylak
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.