[SF7] Remove using container in old migrations #16926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
SYL-3907-remove-container-aware-migrations
branch
from
4ece2b2 to
a1120a0
Compare
Bunnyshell Preview Environment deletedAvailable commands:
|
mpysiak
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SF7, there is no
ContainerAwareInterface, so we cannot use it in migrations anymore. We could handle this in some custom way. Still, these migrations are extremely old, and in my opinion there is no point in maintaining them, because whoever needed to upgrade from those versions of Sylius has already done it, but with new installations they are not needed.