Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product][API][Bug] Fixed product sorting by translated names #13684

Merged
merged 1 commit into from
Feb 23, 2022
Merged

[Product][API][Bug] Fixed product sorting by translated names #13684

merged 1 commit into from
Feb 23, 2022

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Feb 22, 2022

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #12594
License MIT

It resolves the issue with 500 status code on products collection with order[translation.name] parameter.

image

@Rafikooo Rafikooo added the Bug Confirmed bugs or bugfixes. label Feb 22, 2022
@Rafikooo Rafikooo requested a review from a team as a code owner February 22, 2022 15:51
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Feb 22, 2022
@Rafikooo Rafikooo requested a review from GSadee February 22, 2022 19:46
src/Sylius/Behat/Context/Api/Shop/ProductContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Shop/ProductContext.php Outdated Show resolved Hide resolved
@GSadee GSadee merged commit d4e1254 into Sylius:1.10 Feb 23, 2022
@GSadee
Copy link
Member

GSadee commented Feb 23, 2022

Thank you, Rafał! 🥇

GSadee added a commit that referenced this pull request Feb 23, 2022
…adee)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.11
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | after merge #13684 
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

f354e22 [Behat][API] Remove duplicated steps in ProductContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants