-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conflict with doctrine/dbal ^3 to avoid missing json_array
doctrine type error
#13215
Conversation
@Prometee Wouldn't it be better to add a conflict to the conflict section and document it in |
@4c0n yes you are right it will be better to know when and why to remove it one day. |
@Prometee If you use Hope this can get resolved soon, it's causing a lot of extra work for us all, thanks for taking charge. 😃 |
adcc3f4
to
21e58d9
Compare
21e58d9
to
4466a76
Compare
json_array
doctrine type error
@vvasiloi So ^2.7 can/will resolve to https://github.com/doctrine/orm/blob/f346379c7bf39a9f46771cfd9043e0eb2dd98793/composer.json#L26 (https://github.com/doctrine/orm/blob/2.10.1/composer.json) So specifying the conflict on 3.x versions solves the problem and still allows for all the other versions of dbal to be installed. |
@4c0n There shouldn't be an issue if Sylius requires |
Either way, it's better to eventually add an explicit requirement to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say, that requiring dbal is a better approach then to conflict it, but let's unblock all of us with this PR
Thanks, Francis! 🥇 |
When this PR will be released ? This issue is blocking our plugin github actions :( |
…ement (lchrusciel) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | mentioned in #13215 (review) | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- cb7cac8 [Maintenance] Replace dbal conflict with explicit requirement
Same for me :( |
@oallain I found a way to trick it
This will install DBAL 2.x while resolving dependencies |
See #13211 and #13214 for more details about the
json_array
type error.