-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add itemsTotal field to order resource #12661
Conversation
arti0090
commented
May 21, 2021
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
License | MIT |
features/cart/shopping_cart/seeing_detailed_information_about_cart.feature
Outdated
Show resolved
Hide resolved
features/cart/shopping_cart/seeing_detailed_information_about_cart.feature
Show resolved
Hide resolved
74c129c
to
55f1073
Compare
features/cart/shopping_cart/seeing_detailed_information_about_cart.feature
Outdated
Show resolved
Hide resolved
Feature: Seeing detailed information of cart | ||
In order to see detailed information of my cart | ||
As a Visitor | ||
I want to be able to see those information of my cart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to see (...) information, (...), I want to be able to see those information
:( I believe the goal could be described better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that newest changes with my limited humanistic possibilities would fulfill your desires 😄
features/cart/shopping_cart/seeing_detailed_information_about_cart.feature
Outdated
Show resolved
Hide resolved
@@ -516,6 +516,17 @@ public function iCheckItemsOfMyCart(string $tokenValue): void | |||
$this->cartsClient->executeCustomRequest($request); | |||
} | |||
|
|||
/** | |||
* @Then /^my cart should have ("[^"]+") items total$/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/^my cart should have ("[^"]+") items total$/
-> my cart should have :itemsTotal items total
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will work at first it will return (using 12.34 as example) $12.34 but i need 1234 as API returns int number. With ("[^"]+")
I am getting the transformed value of 1234.
src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Order.xml
Outdated
Show resolved
Hide resolved
aa54eee
to
0e88a33
Compare
Thank you, @arti0090! 🎉 |