Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API][Checkout] Implement scenarios for preventing checkout with an empty cart #12006

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Nov 5, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@GSadee GSadee added the API APIs related issues and PRs. label Nov 5, 2020
@GSadee GSadee requested a review from a team as a code owner November 5, 2020 09:24
<constraint name="Sylius\Bundle\ApiBundle\Validator\Constraints\OrderProductEligibility">
<option name="message">sylius.order.product_eligibility</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the message is already defined in OrderProductEligibility constraint

@AdamKasp AdamKasp merged commit c7ebe39 into Sylius:master Nov 5, 2020
@AdamKasp
Copy link
Contributor

AdamKasp commented Nov 5, 2020

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the api-prevent-starting-checkout branch November 5, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants