Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust services to symfony/serializer:^4.4 #11981

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Adjust services to symfony/serializer:^4.4 #11981

merged 1 commit into from
Nov 2, 2020

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

It's required for our ApiPlatform denormalizer implementations. With symfony/serializer in version 4.4, the following error occurs:

Zrzut ekranu 2020-10-30 o 16 47 20

@Zales0123 Zales0123 added Maintenance CI configurations, READMEs, releases, etc. Bug Confirmed bugs or bugfixes. labels Oct 30, 2020
@Zales0123 Zales0123 requested a review from a team as a code owner October 30, 2020 15:50
@Zales0123 Zales0123 force-pushed the require-symfony-serializer-5 branch from 148e355 to 631ef2f Compare October 30, 2020 16:47
lchrusciel
lchrusciel reviewed Nov 1, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@Zales0123 Zales0123 force-pushed the require-symfony-serializer-5 branch from 631ef2f to 3602d51 Compare November 2, 2020 12:46
@Zales0123 Zales0123 changed the title Require symfony/serializer:^5.0 Adjust services to symfony/serializer:^4.4 Nov 2, 2020
@Zales0123 Zales0123 force-pushed the require-symfony-serializer-5 branch from 3602d51 to d53f6fb Compare November 2, 2020 16:12
@lchrusciel lchrusciel merged commit 0b67fa2 into Sylius:1.8 Nov 2, 2020
@lchrusciel
Copy link
Member

Thanks, Mateusz! 🥇

@Zales0123 Zales0123 deleted the require-symfony-serializer-5 branch November 3, 2020 07:05
@lchrusciel lchrusciel mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zales0123 @lchrusciel