Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper parameters in access control patterns #11908

Merged
merged 6 commits into from
Nov 10, 2020

Conversation

loevgaard
Copy link
Contributor

Q A
Branch? 1.8
Bug fix? yes
New feature? no
BC breaks? no
License MIT

@loevgaard loevgaard requested a review from a team as a code owner October 5, 2020 09:13
@lchrusciel lchrusciel changed the base branch from master to 1.8 October 6, 2020 15:18
@lchrusciel lchrusciel changed the base branch from 1.8 to master October 6, 2020 15:19
@lchrusciel lchrusciel changed the base branch from master to 1.8 October 6, 2020 15:27
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-2" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@loevgaard
Copy link
Contributor Author

Should be merged before releasing 1.8.2 :)

@Zales0123 Zales0123 added the Bug Confirmed bugs or bugfixes. label Oct 21, 2020
UPGRADE-1.8.md Outdated Show resolved Hide resolved
@lchrusciel lchrusciel merged commit 63cba55 into Sylius:1.8 Nov 10, 2020
@lchrusciel
Copy link
Member

Thank you, Joachim! 🎉

@loevgaard loevgaard deleted the patch-2 branch November 11, 2020 07:52
@loevgaard
Copy link
Contributor Author

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants