Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Product] Add possibility to create product/variant without price in disabled channels #11848

Merged
merged 2 commits into from
Sep 17, 2020
Merged

[Product] Add possibility to create product/variant without price in disabled channels #11848

merged 2 commits into from
Sep 17, 2020

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch? 1.7
Bug fix? yes
New feature? no
BC breaks? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner September 16, 2020 11:57
GSadee
GSadee reviewed Sep 17, 2020
View reviewed changes
app/migrations/Version20200916093101.php Outdated Show resolved Hide resolved
...es/product/managing_product_variants/adding_product_variant_with_only_original_price.feature Outdated Show resolved Hide resolved
...es/product/managing_product_variants/adding_product_variant_with_only_original_price.feature Outdated Show resolved Hide resolved
features/product/managing_products/adding_product_with_only_original_price.feature Outdated Show resolved Hide resolved
features/product/managing_products/adding_product_with_only_original_price.feature Outdated Show resolved Hide resolved
...es/product/managing_product_variants/adding_product_variant_with_only_original_price.feature Outdated Show resolved Hide resolved
features/product/managing_products/adding_product_with_only_original_price.feature Outdated Show resolved Hide resolved
features/product/managing_products/removing_product_price_from_obsolete_channel.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/ProductContext.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/doctrine/model/ChannelPricing.orm.xml Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the fix-orginal-price-issue-on-product-and-variant branch from e62b751 to 1e14e82 Compare September 17, 2020 07:38
@AdamKasp AdamKasp force-pushed the fix-orginal-price-issue-on-product-and-variant branch from 1e14e82 to 7a3f52b Compare September 17, 2020 12:35
@AdamKasp AdamKasp force-pushed the fix-orginal-price-issue-on-product-and-variant branch from 7a3f52b to 8eedea1 Compare September 17, 2020 12:36
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Sep 17, 2020
@GSadee GSadee merged commit 9d43916 into Sylius:1.7 Sep 17, 2020
@GSadee
Copy link
Member

GSadee commented Sep 17, 2020

Thank you, Adam! 🎉

@AdamKasp AdamKasp deleted the fix-orginal-price-issue-on-product-and-variant branch July 19, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamKasp @GSadee