Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop.first is easier to 0 == loop.index0 #11661

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Loop.first is easier to 0 == loop.index0 #11661

merged 1 commit into from
Jul 20, 2020

Conversation

jacquesbh
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

I just found this and I think it's easier to read loop.first than 0 == loop.index0…

@jacquesbh jacquesbh requested a review from a team as a code owner July 17, 2020 21:14
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Jul 17, 2020
@lchrusciel lchrusciel added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jul 20, 2020
@lchrusciel lchrusciel merged commit 5d48ede into Sylius:master Jul 20, 2020
@lchrusciel
Copy link
Member

Thank you, Jacques! 🎉

@jacquesbh jacquesbh deleted the first-is-lovely branch July 20, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquesbh @lchrusciel