Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Fix build #11560

Merged
merged 2 commits into from
Jun 9, 2020
Merged

[HOTFIX] Fix build #11560

merged 2 commits into from
Jun 9, 2020

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Jun 9, 2020

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Fix build and improve getError() more usable

@Tomanhez Tomanhez requested a review from a team as a code owner June 9, 2020 10:22
lchrusciel
lchrusciel approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, we need to investigate the reason behind these problems and solve them correctly in a proper manner

@lchrusciel lchrusciel added Behat Issues and PRs aimed at improving Behat usage. Bug Confirmed bugs or bugfixes. API APIs related issues and PRs. labels Jun 9, 2020
@lchrusciel lchrusciel changed the title Fix build [HOTFIX] Fix build Jun 9, 2020
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jun 9, 2020
@lchrusciel lchrusciel merged commit e18f1b8 into Sylius:master Jun 9, 2020
@lchrusciel
Copy link
Member

Thanks, Tomasz! 🎉

@Tomanhez Tomanhez mentioned this pull request Jun 9, 2020
Merged
pamil added a commit that referenced this pull request Jun 10, 2020
@pamil
minor #11561 [Travis] Update config on 1.7 with master (Tomanhez)
c27fe6d 
This PR was merged into the 1.8-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.7
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Deprecations?   | no
| License         | MIT

Update from : #11560




Commits
-------

47e412c Disable gpu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Behat Issues and PRs aimed at improving Behat usage. Bug Confirmed bugs or bugfixes. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomanhez @lchrusciel