-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] product association type #11319
[API] product association type #11319
Conversation
oallain
commented
Apr 1, 2020
•
edited
Loading
edited
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Related tickets | partially #11250 |
License | MIT |
- adding_product_association_type.feature
- browsing_product_association_types.feature
- deleting_multiple_product_association_types.feature
- deleting_product_association_type.feature
- editing_product_association_type.feature
- filtering_product_association_types.feature
- product_association_type_unique_code_validation.feature
- product_association_type_validation.feature
381af73
to
5084275
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Olivier,
thanks for your effort ;)
src/Sylius/Behat/Context/Api/Admin/ManagingProductAssociationTypesContext.php
Outdated
Show resolved
Hide resolved
*/ | ||
public function iNameItIn(string $productAssociationTypeName = null, string $localeCode = 'en_US'): void | ||
{ | ||
$this->client->updateRequestData(['translations' => [$localeCode => ['name' => $productAssociationTypeName, 'locale' => $localeCode]]]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we break it into multiple lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, of course.
src/Sylius/Behat/Context/Api/Admin/ManagingProductAssociationTypesContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingProductAssociationTypesContext.php
Outdated
Show resolved
Hide resolved
@@ -10,7 +10,7 @@ Feature: Deleting multiple product association types | |||
And the store has also a product association type "Accessories" | |||
And I am logged in as an administrator | |||
|
|||
@ui | |||
@ui @api | |||
Scenario: Deleting multiple product association types at once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have decided to skip these features because we weren't sure how should we process multiple deletions, but thanks for your proposal! ;)
} | ||
|
||
/** | ||
* @Then this product association type name should be :name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as https://github.com/Sylius/Sylius/pull/11319/files#diff-9f9847e886745cd71df41b26b4816ae1R166
* @Then this product association type name should be :name | |
* @Then /^(this product association type) name should be "([^"]+)"$/ |
} | ||
|
||
/** | ||
* @Then the code field should be disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During implementing new steps, we have decided, that we would like to slightly adjust these steps to something like https://github.com/Sylius/Sylius/pull/11178/files#diff-32a4b0d263dad520cfb84a0704f82849R24
Thanks, @oallain! 🎉 |
This PR was merged into the 1.6-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | part of #11250, improvements from #11319 | License | MIT <!-- - Bug fixes must be submitted against the 1.6 or 1.7 branches (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set --> Commits ------- ce9964f [API] Association types improvements