Add translation key #11314
Merged
Add translation key #11314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used in Sylius\Bundle\LocaleBundle\Form\Type\LocaleChoiceType
oallain
approved these changes
Apr 1, 2020
|
Hello Joachim! Thank you for your fix... but I'm wondering why it was not detected before 😄 To be honest, I see no places where this placeholder is visible in the Admin panel - did you encounter this problem somewhere or just saw a missing translation? :) If it's not needed, maybe we should just remove a |
|
I used the locale choice type in my own project and then I saw the missing translation key. From my point of view it would be no problem to delete although I really like placeholders :D You decide, @Zales0123 ;) |
|
Here is a screenshot so you can see it from my pov
|
lchrusciel
added
Admin
|
Thanks, Joachim! 🥇 |
|
You are very welcome 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in Sylius\Bundle\LocaleBundle\Form\Type\LocaleChoiceType