[Docs] Recommend trait usage in Plugin Development Guide #11111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
the
Documentation
|
Thanks for the further information @Zales0123 , this definetly clears up some misunderstanding. |
AdamKasp
approved these changes
Feb 11, 2020
lchrusciel
approved these changes
Feb 12, 2020
|
PS. Nice PR number 🎉 |
Tomanhez
approved these changes
Mar 3, 2020
lchrusciel
approved these changes
Mar 3, 2020
|
|
||
| # src/Resources/config/config.yml | ||
|
|
||
| sylius_product: |
There was a problem hiding this comment.
What do you think about recommending this configuration in the test folder, so the entity will be checked if wired up properly (and preferably will be a good introduction for testing)
|
Thank you, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time already, we provide all entities overridden in Sylius-Standard. This approach enforces annotations mapping by default but allows Sylius to use multiple plugins extending the same entity at the same time.
We should definitely recommend this approach in our Plugin Development Guide.