Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Installation] Inform about BitBagCommerce/SyliusCmsPlugin after installing Sylius #10979

Merged
merged 1 commit into from
Dec 20, 2019
Merged

[Installation] Inform about BitBagCommerce/SyliusCmsPlugin after installing Sylius #10979

merged 1 commit into from
Dec 20, 2019

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch? 1.5
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner December 20, 2019 08:58
@AdamKasp AdamKasp changed the base branch from master to 1.5 December 20, 2019 08:59
@CoderMaggie CoderMaggie added the DX Issues and PRs aimed at improving Developer eXperience. label Dec 20, 2019
@CoderMaggie CoderMaggie changed the title [Installation] Informs sylius users about cms plugin after sylius installed [Installation] Inform about BitBagCommerce/SyliusCmsPlugin after installing Sylius Dec 20, 2019
CoderMaggie
CoderMaggie requested changes Dec 20, 2019
View reviewed changes
Copy link
Member

@CoderMaggie CoderMaggie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Sylius/Sylius/pull/10979/files#diff-c3cd8c0a36e58b4289fd8e040b497615R38

there we should no longer say it's a list of official Sylius plugins, but a list of official plugins and selected community plugins

@AdamKasp AdamKasp force-pushed the add-cms-plugin-sugestion branch from b88cccf to d8ed6bf Compare December 20, 2019 09:13
@GSadee GSadee merged commit 9c110cb into Sylius:1.5 Dec 20, 2019
@GSadee
Copy link
Member

GSadee commented Dec 20, 2019

Thanks, Adam! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamKasp @GSadee @CoderMaggie