Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payum][Paypal] Use full price instead of discounted one #10938

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

Prometee
Copy link
Contributor

Q A
Branch? 1.4 to master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets unknown
License MIT

I was having trouble with many PayPal errors during the black friday and the error was :
"The totals of the cart item amounts do not match order amounts."

The bug was caused by the fact that PayPal make a validation of the total price with the sum of each item lines we build. This bug appear because all discounted prices are regrouped into an item line named "Discount" so all other lines shouldn't be filled with something related with discounts.

@Prometee Prometee requested a review from a team as a code owner December 13, 2019 14:45
@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Dec 13, 2019
@Zales0123 Zales0123 changed the base branch from master to 1.5 January 8, 2020 12:40
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "payum-paypal" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel merged commit f36502c into Sylius:1.5 Jan 13, 2020
@lchrusciel
Copy link
Member

Thanks, Francis! 🎉

@Prometee Prometee deleted the payum-paypal branch January 13, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants