Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Improve platform.sh documentation for deployment #10916

Merged
merged 1 commit into from
Dec 13, 2019
Merged

[Docs] Improve platform.sh documentation for deployment #10916

merged 1 commit into from
Dec 13, 2019

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Dec 10, 2019 •
edited by GSadee
Loading

Q A
Branch? 1.5
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

@Tomanhez Tomanhez requested a review from a team as a code owner December 10, 2019 13:42
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Dec 11, 2019
lchrusciel
lchrusciel reviewed Dec 11, 2019
View reviewed changes
docs/cookbook/deployment/platform-sh.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/platform-sh.rst Show resolved Hide resolved
docs/getting-started-with-sylius/deployment.rst
@@ -12,123 +12,7 @@ There are many servers which you can choose for your store deployment, but in th
Process
-------

1. Create an account on `Platform.sh <https://platform.sh/>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @CoderMaggie should we remove this part from getting started or keep it duplicated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked that duplicate this is not good solution, link should be enough

@GSadee GSadee changed the base branch from master to 1.5 December 13, 2019 07:57
@GSadee GSadee force-pushed the review-platform-sh branch from 6ef3aa1 to d657d40 Compare December 13, 2019 07:57
@GSadee
Copy link
Member

GSadee commented Dec 13, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "review-platform-sh" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@CoderMaggie CoderMaggie force-pushed the review-platform-sh branch 2 times, most recently from 743a3b2 to 8380238 Compare December 13, 2019 09:03
@GSadee GSadee merged commit 40e8f34 into Sylius:1.5 Dec 13, 2019
@GSadee
Copy link
Member

GSadee commented Dec 13, 2019

Thank you, Tomasz! 🎉

@CoderMaggie CoderMaggie mentioned this pull request Dec 13, 2019
Merged
GSadee added a commit that referenced this pull request Dec 13, 2019
@GSadee
refactor #10935 [Docs] Platform.sh cookbook refinement (CoderMaggie)
8559ddb 
This PR was merged into the 1.5 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.5
| Doc fix?        | yes
| Related tickets | fixes #10916
| License         | MIT

Commits
-------

c2b615b [Docs] Pltform.sh cookbook refinement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tomanhez @GSadee @lchrusciel @Zales0123