Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify BC promise for final controllers #10844

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Nov 12, 2019

There is a very unlikely possibility that one would create a new service based on our final controller class but with different arguments injected to the constructor. It is not a recommended way for sure - we try to keep final controllers as small as possible and the bigger ones are still non-final.

If you're using our final controllers, you're still covered with BC promise.

We need this exception for fixes like #10837.

@pamil pamil added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Documentation Documentation related issues and PRs - requests, fixes, proposals. labels Nov 12, 2019
@pamil pamil requested a review from a team as a code owner November 12, 2019 10:00
@pamil pamil merged commit 25c97c1 into Sylius:1.6 Nov 12, 2019
@pamil pamil deleted the 1.6-bc-promise-final-controllers branch November 12, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants