[Admin] Add link to product in variant breadcrumb #10509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
requested changes
Jul 8, 2019
src/Sylius/Bundle/AdminBundle/Resources/views/ProductVariant/Update/_breadcrumb.html.twig
Outdated
Show resolved
Hide resolved
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
GSadee
force-pushed
the
variant-breadcrumb-link-product
branch
from
567b588 to
b729901
Compare
Tomanhez
force-pushed
the
variant-breadcrumb-link-product
branch
from
b729901 to
eb96557
Compare
Tomanhez
force-pushed
the
variant-breadcrumb-link-product
branch
from
eb96557 to
c3eb989
Compare
CoderMaggie
added
the
Enhancement
GSadee
approved these changes
Jul 9, 2019
|
Thank you, Tomasz! 🥇 |
GSadee
added a commit
that referenced
this pull request
Aug 5, 2019
…nts and PromotionCoupons) (CoderMaggie) This PR was merged into the 1.4 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.4 | Bug fix? | no | New feature? | rather an improvement | BC breaks? | no | Deprecations? | no | Related tickets | triggered by #10509 😄 | License | MIT The clue is to use entities **names** instead of **codes**, wherever it is possible. especially in entities that are _under_ other entities like coupons or variants. Product variant edit: Before:  After:  Without the variant name:  Channels edit: Before:  After:  And while trying to unsuccessfully remove the name:  After (translation of names to Admin locale)    Commits ------- 013134d Improve all breadcrumbs 5a1935f Improve ProductVariant breadcrumbs 14dab4b Improve PromotionCoupon breadcrumbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New link:
After clicking:
to url:
Product edit page:
