Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin][Promotion] Fix removing taxon used in promotion rule #10365

Merged
merged 8 commits into from
May 13, 2019
Merged

[Admin][Promotion] Fix removing taxon used in promotion rule #10365

merged 8 commits into from
May 13, 2019

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented May 8, 2019 •
edited
Loading

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #10225
License MIT

Zrzut ekranu 2019-05-10 o 12 50 29

@GSadee GSadee requested a review from a team as a code owner May 8, 2019 13:04
@GSadee GSadee added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label May 8, 2019
@GSadee GSadee force-pushed the remove-taxon-used-in-promotion branch from 0a701f5 to b1732fa Compare May 9, 2019 07:27
@GSadee GSadee force-pushed the remove-taxon-used-in-promotion branch from b1732fa to 07d39f2 Compare May 9, 2019 14:58
@GSadee GSadee force-pushed the remove-taxon-used-in-promotion branch from dab9ee8 to 1e82d3c Compare May 10, 2019 14:04
@GSadee GSadee force-pushed the remove-taxon-used-in-promotion branch from e3164ab to ee6508a Compare May 13, 2019 07:57
@GSadee GSadee force-pushed the remove-taxon-used-in-promotion branch from ee6508a to 93cd924 Compare May 13, 2019 09:07
lchrusciel
lchrusciel approved these changes May 13, 2019
View reviewed changes
src/Sylius/Behat/Service/NotificationChecker.php
'success' => 'positive',
];

Assert::keyExists($typeClassMap, $type->__toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering, what is better

Suggested change
Assert::keyExists($typeClassMap, $type->__toString());
Assert::keyExists($typeClassMap, (string) $type);

@lchrusciel lchrusciel merged commit 39c3f63 into Sylius:1.3 May 13, 2019
@lchrusciel
Copy link
Member

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the remove-taxon-used-in-promotion branch May 13, 2019 11:09
@Zales0123 Zales0123 mentioned this pull request May 15, 2019
Merged
pamil added a commit that referenced this pull request May 15, 2019
@pamil
bug #10386 [Build Fix][Behat] Change scenarios to @javascript due to …
1bc510b 
…taxon tree changes (Zales0123)

This PR was merged into the 1.3 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.3
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #10228, #10365
| License         | 

Commits
-------

e539ee0 [Behat] Change scenarios to @javascript due to taxon tree changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GSadee @lchrusciel @Zales0123 @Tomanhez