Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix product variants api invalid json #10356

Merged
merged 1 commit into from
May 6, 2019
Merged

Quick fix product variants api invalid json #10356

merged 1 commit into from
May 6, 2019

Conversation

shql
Copy link
Contributor

@shql shql commented May 3, 2019

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

@shql
On the fly fix for product variants api doc
d3c1f74 
The example json response was invalid
@shql shql requested a review from a team as a code owner May 3, 2019 14:20
@shql
Copy link
Contributor Author

shql commented May 3, 2019

Not sure if fixing .rst is a bug fix. Of course this can easily be merged into master as well.

@GSadee GSadee added API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. labels May 6, 2019
@GSadee GSadee merged commit ba8f46a into Sylius:1.3 May 6, 2019
@GSadee
Copy link
Member

GSadee commented May 6, 2019

Thanks, @shql! 🎉

@shql
Copy link
Contributor Author

shql commented May 6, 2019

You're very welcome. That was really just on the fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shql @GSadee