Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Product fixture (fixed #10272) #10281

Merged

Conversation

igormukhingmailcom
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #10272
License MIT

PS: Manually tested with next definitions:

# ...
                tshirt_product:
                    options:
                        amount: 15

                product:
                    options:
                        custom:
                            product_with_slug:
                                code: product_with_slug
                                slug: product-with-slug
                                description: Product with slug
                                channels:
                                    - US_WEB
                                taxons:
                                    - mugs
                                enabled: true

                            product_with_generated_slug:
                                code: product_with_generated_slug
                                name: Product with generated slug
                                channels:
                                    - US_WEB
                                taxons:
                                    - mugs
                                enabled: true

                product_review:
                    options:
                        random: 40
# ...

@igormukhingmailcom igormukhingmailcom requested a review from a team as a code owner April 1, 2019 21:38
@Zales0123 Zales0123 added the Feature New feature proposals. label Apr 3, 2019
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Igor, I guess that you could add simple configuration test here:
ProductFixtureTest.php

@Zales0123 Zales0123 merged commit a49d11d into Sylius:master Apr 9, 2019
@Zales0123
Copy link
Member

Thank you, Igor! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixtures: There are no ability to specify Product's slug
4 participants