Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variant without options values generation #10242

Merged
merged 7 commits into from
Apr 1, 2019
Merged

Fix variant without options values generation #10242

merged 7 commits into from
Apr 1, 2019

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Mar 19, 2019 •
edited
Loading

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9576
License MIT

Screenshot 2019-03-22 at 09 01 05

@Tomanhez Tomanhez requested a review from a team as a code owner March 19, 2019 08:34
Zales0123
Zales0123 reviewed Mar 19, 2019
View reviewed changes
features/product/managing_product_variants/generating_product_variant_without_value.feature Outdated Show resolved Hide resolved
features/product/managing_product_variants/generating_product_variant_without_value.feature Outdated Show resolved Hide resolved
features/product/managing_product_variants/generating_product_variant_without_value.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/ProductContext.php Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/BrowsingProductVariantsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/BrowsingProductVariantsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingProductVariantsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/ProductContext.php Outdated Show resolved Hide resolved
@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Mar 19, 2019
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "without-any-values" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 changed the base branch from master to 1.3 March 19, 2019 08:47
@Zales0123 Zales0123 force-pushed the without-any-values branch from ff02fb0 to a69db59 Compare March 19, 2019 08:47
@Tomanhez Tomanhez changed the title Failing scenario in issue #9576 Failing scenario for variant without options values generation Mar 19, 2019
@Tomanhez Tomanhez force-pushed the without-any-values branch 3 times, most recently from fa6ddb5 to 30d7e64 Compare March 20, 2019 08:59
@Tomanhez Tomanhez changed the title Failing scenario for variant without options values generation Fix variant without options values generation Mar 21, 2019
@Tomanhez Tomanhez force-pushed the without-any-values branch 2 times, most recently from 6385785 to 2c50da0 Compare March 22, 2019 13:55
Zales0123
Zales0123 reviewed Mar 22, 2019
View reviewed changes
...iants/preventing_the_generation_of_products_variants_from_options_without_any_values.feature Outdated Show resolved Hide resolved
...iants/preventing_the_generation_of_products_variants_from_options_without_any_values.feature Outdated Show resolved Hide resolved
...iants/preventing_the_generation_of_products_variants_from_options_without_any_values.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/ProductContext.php Outdated Show resolved Hide resolved
...iants/preventing_the_generation_of_products_variants_from_options_without_any_values.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingProductVariantsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Page/Admin/ProductVariant/GeneratePageInterface.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Page/Admin/ProductVariant/GeneratePage.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/ProductVariant/generate.html.twig Outdated Show resolved Hide resolved
src/Sylius/Component/Product/Generator/ProductVariantGenerator.php Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the without-any-values branch 3 times, most recently from 720a07d to e52a9b3 Compare March 25, 2019 12:47
@Tomanhez Tomanhez force-pushed the without-any-values branch from e52a9b3 to 5b4d8a4 Compare March 27, 2019 11:43
Zales0123
Zales0123 reviewed Mar 28, 2019
View reviewed changes
...iants/preventing_the_generation_of_products_variants_from_options_without_any_values.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingProductVariantsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingProductVariantsContext.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ProductBundle/Form/EventSubscriber/GenerateProductVariantsSubscriber.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ProductBundle/Resources/config/services/form.xml Outdated Show resolved Hide resolved
src/Sylius/Component/Resource/Exception/VariantWithNoOptionsValuesException.php Outdated Show resolved Hide resolved
src/Sylius/Component/Resource/Exception/VariantWithNoOptionsValuesException.php Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the without-any-values branch from 5b4d8a4 to dc99707 Compare March 28, 2019 15:52
@Tomanhez Tomanhez force-pushed the without-any-values branch from dc99707 to 298ee2e Compare March 29, 2019 09:23
Zales0123
Zales0123 reviewed Mar 29, 2019
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the tests are failing due to some undefined steps (probably the wrong suite configuration). Can you take a look at them?

src/Sylius/Bundle/ProductBundle/Form/EventSubscriber/GenerateProductVariantsSubscriber.php Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the without-any-values branch from 298ee2e to accc939 Compare March 29, 2019 11:06
@Tomanhez Tomanhez force-pushed the without-any-values branch from accc939 to 3228f93 Compare March 29, 2019 11:36
@Zales0123 Zales0123 merged commit 8f5198a into Sylius:1.3 Apr 1, 2019
@Zales0123
Copy link
Member

Thank you, Tomasz! 🥇

@Zales0123 Zales0123 mentioned this pull request Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie left review comments

@lchrusciel lchrusciel lchrusciel left review comments

@GSadee GSadee GSadee left review comments

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tomanhez @Zales0123 @GSadee @lchrusciel @CoderMaggie