Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the Checkout state validator. #676

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Fixing the Checkout state validator. #676

merged 2 commits into from
Dec 9, 2020

Conversation

mamazu
Copy link
Member

@mamazu mamazu commented Oct 8, 2020

Closes #665

@mamazu mamazu requested a review from a team as a code owner October 8, 2020 07:12
lchrusciel
lchrusciel approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a possibility to cover a new case, which will protect us from the regression?

@mamazu
Copy link
Member Author

mamazu commented Oct 21, 2020

I could add one but I don't know how someone can manage to get the cart into such a state.

@lchrusciel
Copy link
Member

We should try to complete cart, which is not addresses/shipment is not selected/payment is not selected

@mamazu
Copy link
Member Author

mamazu commented Oct 23, 2020

Valid point I will add that.

@mamazu
Copy link
Member Author

mamazu commented Oct 29, 2020

We already have a test for this:
https://github.com/Sylius/ShopApiPlugin/blob/master/tests/Controller/Checkout/CompleteOrderApiTest.php#L391

@lchrusciel lchrusciel changed the base branch from master to 1.2 December 9, 2020 10:39
@lchrusciel lchrusciel merged commit 26c4368 into Sylius:1.2 Dec 9, 2020
@lchrusciel
Copy link
Member

Thanks, @mamazu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] CartReadyForCheckoutValidator checks against order state, not order checkout state
2 participants
@mamazu @lchrusciel