-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email validation to RequestResetPassword #621
Conversation
b25b7ba
to
0f65d97
Compare
f5522ac
to
133f48c
Compare
I have fixed the codestyle in your branch and added the information about the change in behavior in the change logs and rebased it onto the master so the pipeline should be green now.
|
@mamazu Thanks for your review I will check them, I have updated my local branch, I got stuck for some time, but It worked thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request looks good. However the pipeline still fails with codestyle issues. You can run composer fix
to fix them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, if you can fix the tests. But I definitely want to wait until @lchrusciel also approves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work. My comments are mostly small CS related stuff.
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
@mamazu @lchrusciel Thanks for your review, it was so helpful, I have fixed the specs. |
If you can fix the tests then it should be good to go. |
@mamazu Many Thanks for your help, I fixed them |
Thanks, Amr! 🥇 |
Add email Validation to RequestResetPassword
#618