Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taking over "Objective C Storyboard swizzling #46" #67

Closed
wants to merge 19 commits into from
Closed

Taking over "Objective C Storyboard swizzling #46" #67

wants to merge 19 commits into from

Conversation

yoichitgy
Copy link
Member

Resolved installation problems on PR #46.

mpdifran and others added 19 commits June 7, 2017 15:41
@mpdifran
Objective C Storyboard swizzling
13dae8f
@mpdifran
Fix last warning for using initialize in Swift.
57eb6ff 
Replace the SwinjectStoryboardProtocol file with an ObjC one.
Call the setup class method from the ObjC category SwinjectStoryboard+SetUp..
@mpdifran
Update travis to use Xcode 8.3.2
d907f41
@yoichitgy
Revert "Update travis to use Xcode 8.3.2"
d66d631 
This reverts commit d907f41.
@yoichitgy
Fix .travis.yml by adding —platform iOS,macOS,tvOS.
9e49932
@yoichitgy
Use Xcode 8.3 on Travis.
a08674b
@yoichitgy
Remove verbose option from carthage bootstrap.
2f182e7
@yoichitgy
Add .swift-version for pod lib.
38fc2c0
@yoichitgy
Update Carthage on Travis to use --cache-builds option.
2d8b560
@yoichitgy
Add .m and .h files to pod spec.
4a22b3d
@yoichitgy
Remove an unnecessary header file that imports SwinjectStoryboard/Swi…
9e9c9a0 
…njectStoryboard-Swift.h
@yoichitgy
Remove pbxproj settings that were made by accident.
1773461
@yoichitgy
Fix parameter names in code documentation.
54c04be
@yoichitgy
Expose isCreatingStoryboardReference property and createReferenced me…
e5d2043 
…thod to Objective-C.

I actually want to revert this commit not to make the property and method public because they are not intended to be used by users of SwinjectStoryboard.
@yoichitgy
Remove workaround in podspec that is no longer needed for the latest …
b59168e 
…version of CocoaPods.
@yoichitgy
Revert "Expose isCreatingStoryboardReference property and createRefer…
99229c9 
…enced method to Objective-C."

This reverts commit e5d2043.
@yoichitgy
performSelector to use internal class methods defined in Swift.
e167df7
@yoichitgy
Merge branch 'master' into objCSwizzle
bc6806a 
# Conflicts:
#	Sources/SwinjectStoryboardProtocol.swift
@yoichitgy
Remove ifdef to check platforms because it’s redundant now.
2d623bd
@yoichitgy yoichitgy added this to the v1.2.0 milestone Aug 24, 2017
@yoichitgy yoichitgy mentioned this pull request Aug 24, 2017
Merged
@yoichitgy yoichitgy closed this Aug 25, 2017
@yoichitgy yoichitgy deleted the objCSwizzle branch August 25, 2017 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@yoichitgy @mpdifran