Objective C Storyboard swizzling #46

mpdifran · 2017-04-16T18:35:31Z

DO NOT MERGE: work in progress.

EDIT: It is now ready for merge once we update TravisCI.

mpdifran · 2017-04-16T18:36:31Z

Sources/Storyboard+Swizzling.m

+    if (self == [Storyboard class]) {
+
+        // Instantiate SwinjectStoryboard if UI/NSStoryboard is trying to be instantiated.
+        if [SwinjectStoryboard isCreatingStoryboardReference] {


Need to #import "SwinjectStoryboard-Swift.h" in order to access this Swift class method, but for some reason the header is not automatically generated.

@mpdifran, I'll reply shortly.

Hi @mpdifran. I took time for my misunderstanding.

Usually a bridging header is required to access objc classes or methods from Swift. If you need to expose Swift class, you can just add @objc annotation. If the problem is that isCreatingStoryboardReference is defined as static var, you can change it to class var.

Am I missing the point of your comment?

You're right, the bridging header is for accessing ObjC classes in Swift, but in this case, we're accessing a Swift class in ObjC. From what I've read online, there should be an automatically generated header named SwinjectStoryboard-Swift.h that we can import in our ObjC files.

But maybe adding the @objc to the class and changing the static var to a class var will work. I'll give that a shot.

mpdifran · 2017-04-21T02:39:30Z

Updated to use @objc, but it's still having issues finding the SwinjectStoryboard Swift class:

/Users/mpdifran/Sandbox/SwinjectStoryboard/Sources/Storyboard+Swizzling.m:56:14: error: use of undeclared identifier 'SwinjectStoryboard'
    if ([SwinjectStoryboard isCreatingStoryboardReference]) {
         ^

yoichitgy · 2017-04-23T00:32:02Z

@mpdifran, I reproduced the issue. As you said, we needed to import SwinjectStoryboard-Swift.h which is specified in the project as Objective-C Generated Interface Header Name. I checked some stackoviewflow answers, but still I couldn't find a solution. I keep solving this problem.

yoichitgy · 2017-04-23T20:22:14Z

I followed the section below in the Apple's official document, but still SwinjectStoryboard/SwinjectStoryboard-Swift.h cannot be imported...

"Importing Code from Within the Same Framework Target"
- "Importing Swift into Objective-C"

https://developer.apple.com/library/content/documentation/Swift/Conceptual/BuildingCocoaApps/MixandMatch.html

mpdifran · 2017-04-23T23:46:47Z

Sources/Storyboard+Swizzling.m

+
+#import "Storyboard+Swizzling.h"
+#import <objc/runtime.h>
+#import <SwinjectStoryboard/SwinjectStoryboard-Swift.h>


This seems to be the correct way to import the header.

mpdifran · 2017-04-23T23:52:52Z

I'm still getting one warning on public override class func initialize() in SwinjectStoryboard.swift. Any ideas for how to solve that?

yoichitgy · 2017-04-30T21:00:48Z

@mpdifran, I'm sorry I took time to respond.

Do you have any change since the last week? I will fetch your commit to check the warning on public override class func initialize(). Thanks😃

mpdifran · 2017-04-30T23:15:57Z

Nope, haven't taken a look at it since.

yoichitgy · 2017-04-30T23:45:26Z

@mpdifran Do you no longer have the error to import the header file? I still have error here in Storyboard+Swizzling.m.

#import <SwinjectStoryboard/SwinjectStoryboard-Swift.h>

mpdifran · 2017-05-01T00:54:14Z

Ah looks like I hadn't pushed up my recent changes. I just did a force push, try pulling down the branch again.

Also, correct, I am able to build the project fine; I don't see the header error.

mpdifran · 2017-05-01T03:18:44Z

Tests/Container+SwinjectStoryboardSpec.swift

@@ -26,7 +26,7 @@ class Container_SwinjectStoryboardSpec: QuickSpec {
                expect(container.description) ==
                    "[\n"
                    + "    { Service: \(controllerType), Storyboard: SwinjectStoryboardTests.AnimalViewController, "
-                    + "Factory: ((Resolver, \(controllerType))) -> \(controllerType), ObjectScope: graph, InitCompleted: Specified }\n"
+                    + "Factory: (Resolver, \(controllerType)) -> \(controllerType), ObjectScope: graph, InitCompleted: Specified }\n"


Not sure why, but this test was failing, and I needed to make this change in order to make it pass.

It's difference between Swift 3.0 and 3.1. Swift 3.1 fixed the doubly printed tuple: ((a, b))
Swinject/Swinject#252

Ah ok cool.

yoichitgy · 2017-05-02T02:25:44Z

Thanks @mpdifran👍 I confirmed the build passed with the swift header imported. I'm going to check the issue on public override class func initialize().

yoichitgy · 2017-05-10T05:46:02Z

I'll investigate public override class func initialize() in SwinjectStoryboard.swift in this weekend😉

mpdifran · 2017-05-19T00:44:45Z

Just did a rebase and force push to fix the merge conflicts. @yoichitgy I'll be around this weekend if you want some help tackling this.

mpdifran · 2017-05-19T01:07:50Z

I think I've fixed the last warning. Let me know if you approve of this implementation.

mpdifran · 2017-05-20T02:22:16Z

Looks like the tests are failing. I'll take another look sometime soon.

mpdifran · 2017-05-27T23:58:24Z

Fixed the failing test. Moved the + (void)load override into a category on SwinjectStoryboard instead of UIStoryboard in order to get the proper protocol conformance.

mpdifran · 2017-05-28T00:03:44Z

Sources/SwinjectStoryboard.swift

+        bundle storyboardBundleOrNil: Bundle?) -> SwinjectStoryboard {
+        return SwinjectStoryboard.create(name: name, bundle: storyboardBundleOrNil,
+                                         container: SwinjectStoryboard.defaultContainer)
+    }


This needed to be done because ObjC doesn't support Swift's default parameters (container: Resolver = SwinjectStoryboard.defaultContainer). These two methods are functionally equivalent to the single old method, so the API hasn't actually changed.

yoichitgy · 2017-06-19T05:06:00Z

I'm sorry, but I'll continue working on Podspec in a few days 🙇

mpdifran · 2017-07-24T23:01:48Z

@yoichitgy do you think you'll have a chance to fix the pod spec soon?

yoichitgy · 2017-07-28T11:52:32Z

Sorry @mpdifran for my late response for this valuable pull request😱 I was too busy for a big project as my job to work on Swinject projects, but I got knowledge about podspec a lot in the project. I will try to solve the problem within a few weeks🏃

…njectStoryboard-Swift.h

yoichitgy · 2017-08-06T03:53:17Z

@mpdifran, I resolved the following issue on pod lib lint in this branch.

'SwinjectStoryboard/SwinjectStoryboard-Swift.h' file not found

Now I got new errors:

error: no known class method for selector 'isCreatingStoryboardReference'
error: no known class method for selector 'createReferencedWithName:bundle:'

I'm working on the issues now.

yoichitgy · 2017-08-06T06:50:27Z

The cause of the new errors is this:

https://developer.apple.com/library/content/documentation/Swift/Conceptual/BuildingCocoaApps/MixandMatch.html

Because the generated header for a framework target is part of the framework’s public interface, only declarations marked with the public or open modifier appear in the generated header for a framework target.

Swift methods and properties that are marked with the internal modifier and declared within a class that inherits from an Objective-C class are accessible to the Objective-C runtime. However, they are not accessible at compile time and do not appear in the generated header for a framework target.

For framework targets, only declarations with the public or open modifier appear in the generated header. You can still use Swift methods and properties that are marked with the internal modifier from within the Objective-C part of your framework, as long they are declared within a class that inherits from an Objective-C class. For more information on access-level modifiers, see Access Control in The Swift Programming Language (Swift 4).

…thod to Objective-C. I actually want to revert this commit not to make the property and method public because they are not intended to be used by users of SwinjectStoryboard.

yoichitgy · 2017-08-06T08:43:09Z

I solved the pod lib lint issues in this branch, but I want to revert the commit (e5d2043) not to expose those methods that should not be used by SwinjectStoryboard users.

@mpdifran, do you have any idea to revert the commit and solve the problem by another way?

(I made a pull request to merge my changes into your pull request.)

…version of CocoaPods.

mpdifran · 2017-08-06T14:00:47Z

Let me take a look at it when I get a chance. Was this issue introduced due to the pod lib lint changes? I’ve been using this branch through Carthage with no issues...

yoichitgy · 2017-08-06T16:10:20Z

I'm still not sure the cause of the problem that internal methods are not exposed to SwinjectStoryboard-Swift.h with CocoaPods. If pod lib lint experiences the problem, CocoaPods users will see the problem.

I didn't get the problem when I built SwinjectStoryboard project, but it might be reproducible if you install SwinjectStoryboard to an app project by Carthage. (I didn't try this yet.)

mpdifran · 2017-08-07T12:49:31Z

I'm currently using this branch in one of my apps through Carthage, so there's no problem on the Carthage side.

yoichitgy · 2017-08-09T12:01:01Z

Thanks @mpdifran👍 I'll investigate podspec to make those method internal in this weekend.

yoichitgy · 2017-08-16T01:01:09Z

I'm trying to resolve the issue by fixing directions of Swift/ObjC references.

…enced method to Objective-C." This reverts commit e5d2043.

# Conflicts: # Sources/SwinjectStoryboardProtocol.swift

yoichitgy · 2017-08-24T14:44:17Z

@mpdifran, I made PR #67 taking over your PR to fix the installation issue. Your PR will be automatically merged when #67 is merged.

At the end, I ended up with performSelector to call internal class methods defined in Swift. Not perfect but we didn't expose unnecessary methods to users of SwinjectStoryboard.

Thank you for your investigation, fix and patience😃😃😃

Update of your pull request Swinject#46 to Swinject/SwinjectStoryboard

yoichitgy · 2017-08-25T04:33:21Z

Thanks @mpdifran for merging my branch👍

mpdifran commented Apr 16, 2017

View reviewed changes

mpdifran mentioned this pull request Apr 16, 2017

Objective-C class method 'initialize', which is not guaranteed to be invoked by Swift and will be disallowed in future versions #45

Closed

yoichitgy added this to the v1.2.0 milestone Apr 20, 2017

mpdifran force-pushed the objCSwizzle branch from 1a87504 to 3c0d68c Compare April 21, 2017 02:37

mpdifran force-pushed the objCSwizzle branch 3 times, most recently from 38fbbe2 to 4fd7f18 Compare April 21, 2017 02:45

mpdifran force-pushed the objCSwizzle branch from 4fd7f18 to d26a47f Compare April 23, 2017 23:46

mpdifran commented Apr 23, 2017

View reviewed changes

mpdifran force-pushed the objCSwizzle branch from d26a47f to df6adc2 Compare May 1, 2017 00:52

mpdifran force-pushed the objCSwizzle branch from df6adc2 to d073969 Compare May 1, 2017 01:11

mpdifran commented May 1, 2017

View reviewed changes

mpdifran force-pushed the objCSwizzle branch from d073969 to da03faf Compare May 19, 2017 00:43

mpdifran changed the title ~~WIP: Objective C Storyboard swizzling~~ Objective C Storyboard swizzling May 19, 2017

mpdifran force-pushed the objCSwizzle branch from d1137d8 to f915fce Compare May 27, 2017 23:57

mpdifran commented May 28, 2017

View reviewed changes

yoichitgy added 3 commits August 6, 2017 12:35

Add .m and .h files to pod spec.

4a22b3d

Remove an unnecessary header file that imports SwinjectStoryboard/Swi…

9e9c9a0

…njectStoryboard-Swift.h

Remove pbxproj settings that were made by accident.

1773461

yoichitgy added 2 commits August 6, 2017 17:13

Fix parameter names in code documentation.

54c04be

Expose isCreatingStoryboardReference property and createReferenced me…

e5d2043

…thod to Objective-C. I actually want to revert this commit not to make the property and method public because they are not intended to be used by users of SwinjectStoryboard.

Remove workaround in podspec that is no longer needed for the latest …

b59168e

…version of CocoaPods.

yoichitgy mentioned this pull request Aug 6, 2017

Update of your pull request #46 to Swinject/SwinjectStoryboard mpdifran/SwinjectStoryboard#1

Merged

yoichitgy mentioned this pull request Aug 15, 2017

Ability to pass arguments #62

Open

yoichitgy mentioned this pull request Aug 22, 2017

SwinjectStoryboard setup function no longer called automatically #63

Closed

yoichitgy added 4 commits August 24, 2017 23:19

Revert "Expose isCreatingStoryboardReference property and createRefer…

99229c9

…enced method to Objective-C." This reverts commit e5d2043.

performSelector to use internal class methods defined in Swift.

e167df7

Merge branch 'master' into objCSwizzle

bc6806a

# Conflicts: # Sources/SwinjectStoryboardProtocol.swift

Remove ifdef to check platforms because it’s redundant now.

2d623bd

yoichitgy mentioned this pull request Aug 24, 2017

Taking over "Objective C Storyboard swizzling #46" #67

Closed

Merge pull request #1 from yoichitgy/objCSwizzle

051424e

Update of your pull request Swinject#46 to Swinject/SwinjectStoryboard

yoichitgy merged commit 285cb0b into Swinject:master Aug 25, 2017

mpdifran deleted the objCSwizzle branch August 25, 2017 21:29

Objective C Storyboard swizzling #46

Objective C Storyboard swizzling #46

Conversation

mpdifran commented Apr 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yoichitgy Apr 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpdifran commented Apr 21, 2017

yoichitgy commented Apr 23, 2017

yoichitgy commented Apr 23, 2017

Choose a reason for hiding this comment

mpdifran commented Apr 23, 2017

yoichitgy commented Apr 30, 2017

mpdifran commented Apr 30, 2017

yoichitgy commented Apr 30, 2017

mpdifran commented May 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yoichitgy commented May 2, 2017

yoichitgy commented May 10, 2017

mpdifran commented May 19, 2017

mpdifran commented May 19, 2017

mpdifran commented May 20, 2017

mpdifran commented May 27, 2017

Choose a reason for hiding this comment

yoichitgy commented Jun 19, 2017

mpdifran commented Jul 24, 2017

yoichitgy commented Jul 28, 2017

yoichitgy commented Aug 6, 2017

yoichitgy commented Aug 6, 2017

yoichitgy commented Aug 6, 2017 • edited Loading

mpdifran commented Aug 6, 2017

yoichitgy commented Aug 6, 2017 • edited Loading

mpdifran commented Aug 7, 2017

yoichitgy commented Aug 9, 2017

yoichitgy commented Aug 16, 2017

yoichitgy commented Aug 24, 2017

yoichitgy commented Aug 25, 2017 • edited Loading

mpdifran commented Apr 16, 2017 •

edited

Loading

yoichitgy Apr 20, 2017 •

edited

Loading

yoichitgy commented Aug 6, 2017 •

edited

Loading

yoichitgy commented Aug 6, 2017 •

edited

Loading

yoichitgy commented Aug 25, 2017 •

edited

Loading