Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported Swift versions to SwiftyBeaver.podspec #371

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Add supported Swift versions to SwiftyBeaver.podspec #371

merged 2 commits into from
Nov 5, 2019

Conversation

RomanPodymov
Copy link
Contributor

@RomanPodymov RomanPodymov commented Nov 4, 2019

Hello.
Thank you for SwiftyBeaver.
In this pull request I added supported Swift versions to SwiftyBeaver.podspec. Currently getting the following error: - SwiftyBeaver-iOS does not specify a Swift version and none of the targets integrating it have the SWIFT_VERSION attribute set. Please contact the author or set the SWIFT_VERSION attribute in at least one of the targets that integrate this pod.

@skreutzberger
Copy link
Collaborator

Would it make sense to also add Swift 3 and Swift 4 here?

@RomanPodymov
Copy link
Contributor Author

Hello @skreutzberger
Not sure if SwiftyBeaver supports Swift 3 and Swift 4. In Package.swift I see swift-tools-version:5.0.

@skreutzberger
Copy link
Collaborator

SwiftyBeaver supports Swift 3, 4 & 5

@RomanPodymov
Copy link
Contributor Author

@skreutzberger Done.

@skreutzberger
Copy link
Collaborator

Thank you! It will be part of the next release.

@skreutzberger skreutzberger merged commit 9ea7404 into SwiftyBeaver:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants