This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
Clibgraphviz: repair the modular build #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the module build seems to differ for WinSDK and the clibgraphviz which includes `Windows.h`. This header is unnecessary and has been pushed upstream (https://gitlab.com/graphviz/graphviz/-/merge_requests/1930) as well for removal. This enables us to build the module on Windows.
|
@mattt what do you think of this as a means for unblocking Windows? The expectation is that the same change will occur upstream anyways asynchronously. |
mattt
approved these changes
Apr 28, 2021
|
I think this is fine for now. Thanks for making the change here and upstream. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the module build seems to differ for WinSDK and the
clibgraphviz which includes
Windows.h. This header is unnecessary andhas been pushed upstream
(https://gitlab.com/graphviz/graphviz/-/merge_requests/1930) as well for
removal. This enables us to build the module on Windows.