Mark Summary and Details as block items #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub6Resources
requested changes
May 23, 2023
| styledElement.style = Style( | ||
| display: Display.block, | ||
| ); | ||
| break; |
There was a problem hiding this comment.
This style needs to be added to DetailsElementBuiltIn in the prepare method, rather than this class.
There was a problem hiding this comment.
You're sort of right in the StyledElementBuiltin it indeed doesn't do anything. However if I add it into the DetailsElementBuiltin it causes different rendering issues. I removed it for Summary and left it in just for Details; this seems to work properly.
Sub6Resources
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1275 and also adds a test case for it.