Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues brought up by pub.dev score analyzer #1088

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

Sub6Resources
Copy link
Owner

@Sub6Resources Sub6Resources commented Jun 13, 2022

This pull request touches on a lot of files, but the changes are almost entirely cosmetic:

Documentation comments
Running flutter format on all files
Adding barebones "example" directories to the subpackages
Upgrading the numerus dependency.
Upgrading pubspec.yaml subpackage descriptions.

@erickok
Copy link
Collaborator

erickok commented Jun 14, 2022

LGTM. What line length limit are you using? Just so we (I) can use the same in the future and it's not so easy to get formatting-only changes in PRs.

@Sub6Resources
Copy link
Owner Author

I just have it set at the default (80). Not my favorite, but probably easier to encourage others to format code in pull requests if we use the default options.

@Sub6Resources Sub6Resources merged commit 9bf0662 into master Jun 14, 2022
@Sub6Resources Sub6Resources deleted the pub-score-fixes branch June 14, 2022 16:26
@erickok
Copy link
Collaborator

erickok commented Jun 14, 2022

Yeah same - not my fav but probably the best choice for the project. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants